Commit 8f8f5885 authored by Markus Armbruster's avatar Markus Armbruster
Browse files

vfio: Report warnings with warn_report(), not error_printf() 



Cc: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Message-Id: <20190417190641.26814-8-armbru@redhat.com>
Acked-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent d081cedd

hw/vfio/pci.c

+13 −6
Original line number Diff line number Diff line
@@ -947,8 +947,10 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev) 
    if (vdev->pdev.romfile || !vdev->pdev.rom_bar) {

        /* Since pci handles romfile, just print a message and return */

        if (vfio_blacklist_opt_rom(vdev) && vdev->pdev.romfile) {

            error_printf("Warning : Device at %s is known to cause system instability issues during option rom execution. Proceeding anyway since user specified romfile\n",

            warn_report("Device at %s is known to cause system instability"

                        " issues during option rom execution",

                        vdev->vbasedev.name);

            error_printf("Proceeding anyway since user specified romfile\n");

        }

        return;

    }
@@ -973,11 +975,16 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev) 


    if (vfio_blacklist_opt_rom(vdev)) {

        if (dev->opts && qemu_opt_get(dev->opts, "rombar")) {

            error_printf("Warning : Device at %s is known to cause system instability issues during option rom execution. Proceeding anyway since user specified non zero value for rombar\n",

            warn_report("Device at %s is known to cause system instability"

                        " issues during option rom execution",

                        vdev->vbasedev.name);

            error_printf("Proceeding anyway since user specified"

                         " non zero value for rombar\n");

        } else {

            error_printf("Warning : Rom loading for device at %s has been disabled due to system instability issues. Specify rombar=1 or romfile to force\n",

            warn_report("Rom loading for device at %s has been disabled"

                        " due to system instability issues",

                        vdev->vbasedev.name);

            error_printf("Specify rombar=1 or romfile to force\n");

            return;

        }

    }