Commit 8f3bf50d authored by Kevin Wolf's avatar Kevin Wolf
Browse files

iscsi: Support auto-read-only option 



If read-only=off, but auto-read-only=on is given, open the volume
read-write if we have the permissions, but instead of erroring out for
read-only volumes, just degrade to read-only.

Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
parent 54ea21bd

block/iscsi.c

+5 −3
Original line number Diff line number Diff line
@@ -1878,10 +1878,12 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags, 
    /* Check the write protect flag of the LUN if we want to write */

    if (iscsilun->type == TYPE_DISK && (flags & BDRV_O_RDWR) &&

        iscsilun->write_protected) {

        error_setg(errp, "Cannot open a write protected LUN as read-write");

        ret = -EACCES;

        ret = bdrv_apply_auto_read_only(bs, "LUN is write protected", errp);

        if (ret < 0) {

            goto out;

        }

        flags &= ~BDRV_O_RDWR;

    }



    iscsi_readcapacity_sync(iscsilun, &local_err);

    if (local_err != NULL) {