Commit 8c957053 authored by Yonit Halperin's avatar Yonit Halperin Committed by Gerd Hoffmann
Browse files

spice: adding seamless-migration option to the command line 



The seamless-migration flag is required in order to identify
whether libvirt supports the new QEVENT_SPICE_MIGRATE_COMPLETED or not
(by default the flag is off).
New libvirt versions that wait for QEVENT_SPICE_MIGRATE_COMPLETED should turn on this flag.
When this flag is off, spice fallbacks to its old migration method, which
can result in data loss.

Signed-off-by: default avatarYonit Halperin <yhalperi@redhat.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 61c4efe2

qemu-config.c

+3 −0
Original line number Diff line number Diff line
@@ -537,6 +537,9 @@ QemuOptsList qemu_spice_opts = { 
        },{

            .name = "playback-compression",

            .type = QEMU_OPT_BOOL,

        }, {

            .name = "seamless-migration",

            .type = QEMU_OPT_BOOL,

        },

        { /* end of list */ }

    },

qemu-options.hx

+3 −0
Original line number Diff line number Diff line
@@ -920,6 +920,9 @@ Enable/disable passing mouse events via vdagent. Default is on. 
@item playback-compression=[on|off]

Enable/disable audio stream compression (using celt 0.5.1).  Default is on.



@item seamless-migration=[on|off]

Enable/disable spice seamless migration. Default is off.



@end table

ETEXI

ui/spice-core.c

+7 −0
Original line number Diff line number Diff line
@@ -585,6 +585,9 @@ void qemu_spice_init(void) 
    int port, tls_port, len, addr_flags;

    spice_image_compression_t compression;

    spice_wan_compression_t wan_compr;

#if SPICE_SERVER_VERSION >= 0x000b02 /* 0.11.2 */

    bool seamless_migration;

#endif



    qemu_thread_get_self(&me);
@@ -728,6 +731,10 @@ void qemu_spice_init(void) 
    spice_server_set_uuid(spice_server, qemu_uuid);

#endif



#if SPICE_SERVER_VERSION >= 0x000b02 /* 0.11.2 */

    seamless_migration = qemu_opt_get_bool(opts, "seamless-migration", 0);

    spice_server_set_seamless_migration(spice_server, seamless_migration);

#endif

    if (0 != spice_server_init(spice_server, &core_interface)) {

        error_report("failed to initialize spice server");

        exit(1);