Commit 8bd6b06d authored by Stefan Weil's avatar Stefan Weil Committed by Anthony Liguori
Browse files

console: Fix warning from clang (and potential crash) 



ccc-analyzer reports this warning:

console.c:1090:29: warning: Dereference of null pointer
        if (active_console->cursor_timer) {
                            ^

Function console_select allows active_console to be NULL,
but would crash when accessing cursor_timer. Fix this.

Reviewed-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: default avatarStefan Weil <sw@weilnetz.de>
Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
parent 23aec600

console.c

+1 −1
Original line number Diff line number Diff line
@@ -1087,7 +1087,7 @@ void console_select(unsigned int index) 
    if (s) {

        DisplayState *ds = s->ds;



        if (active_console->cursor_timer) {

        if (active_console && active_console->cursor_timer) {

            qemu_del_timer(active_console->cursor_timer);

        }

        active_console = s;