Commit 8b6ee9ae authored by Stefan Hajnoczi's avatar Stefan Hajnoczi Committed by Kevin Wolf
Browse files

checkpatch: complain about ffs(3) calls 



The ffs(3) family of functions is not portable.  MinGW doesn't always
provide the function.

Use ctz32() or ctz64() instead.

Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Message-id: 1427124571-28598-10-git-send-email-stefanha@redhat.com
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent f450a858

scripts/checkpatch.pl

+11 −0
Original line number Diff line number Diff line
@@ -2911,6 +2911,17 @@ sub process { 
		if ($rawline =~ /\b(?:Qemu|QEmu)\b/) {

			WARN("use QEMU instead of Qemu or QEmu\n" . $herecurr);

		}



# check for non-portable ffs() calls that have portable alternatives in QEMU

		if ($line =~ /\bffs\(/) {

			ERROR("use ctz32() instead of ffs()\n" . $herecurr);

		}

		if ($line =~ /\bffsl\(/) {

			ERROR("use ctz32() or ctz64() instead of ffsl()\n" . $herecurr);

		}

		if ($line =~ /\bffsll\(/) {

			ERROR("use ctz64() instead of ffsll()\n" . $herecurr);

		}

	}



	# If we have no input at all, then there is nothing to report on