Commit 8b1402ce authored by Vladimir Sementsov-Ogievskiy's avatar Vladimir Sementsov-Ogievskiy Committed by John Snow
Browse files

block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap 



Add locks and remove comments about BQL accordingly to
dirty_bitmap_mutex definition in block_int.h.

Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
Reviewed-by: default avatarJeff Cody <jcody@redhat.com>
Message-id: 20180606182449.1607-2-jsnow@redhat.com
Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
parent b133c27f

block/dirty-bitmap.c

+4 −2
Original line number Diff line number Diff line
@@ -413,18 +413,20 @@ void bdrv_remove_persistent_dirty_bitmap(BlockDriverState *bs, 
    }

}



/* Called with BQL taken.  */

void bdrv_disable_dirty_bitmap(BdrvDirtyBitmap *bitmap)

{

    bdrv_dirty_bitmap_lock(bitmap);

    assert(!bdrv_dirty_bitmap_frozen(bitmap));

    bitmap->disabled = true;

    bdrv_dirty_bitmap_unlock(bitmap);

}



/* Called with BQL taken.  */

void bdrv_enable_dirty_bitmap(BdrvDirtyBitmap *bitmap)

{

    bdrv_dirty_bitmap_lock(bitmap);

    assert(!bdrv_dirty_bitmap_frozen(bitmap));

    bitmap->disabled = false;

    bdrv_dirty_bitmap_unlock(bitmap);

}



BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs)