Commit 8af6bb14 authored by Marc-André Lureau's avatar Marc-André Lureau Committed by Markus Armbruster
Browse files

monitor: accept input on resume 



A chardev may stop trying to write if the associated can_read()
callback returned 0. This happens when the monitor is suspended.
The frontend is supposed to call qemu_chr_fe_accept_input() when it is
ready to accept data again.

An issue was observed with a spice port: pending commands may be
delayed, as the chardev is not flushed. Most chardev don't use the
accept_input() callback, and instead check regularly if they can
write. The ones that do use it are braille, mux, msmouse,
spice (abstract), spicevmc, spiceport, wctablet.

Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20180817173752.19136-1-marcandre.lureau@redhat.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
parent 3d7a1c44

monitor.c

+1 −0
Original line number Diff line number Diff line
@@ -4411,6 +4411,7 @@ void monitor_resume(Monitor *mon) 
            assert(mon->rs);

            readline_show_prompt(mon->rs);

        }

        qemu_chr_fe_accept_input(&mon->chr);

    }

    trace_monitor_suspend(mon, -1);

}