Commit 8acc216b authored by Peter Maydell's avatar Peter Maydell
Browse files

disas/libvixl: Suppress gcc 4.6.3 sign-compare warnings 



The VIXL code includes some equality comparisons between signed
and unsigned types. Modern gcc and clang do not complain about
these, but older versions of gcc such as gcc 4.6.3 do. Since
libvixl is an upstream library, the simplest approach is to
suppress the warnings by applying -Wno-sign-compare to the
relevant files.

(GCC 4.6 is not quite yet irrelevant for us; it is the gcc
shipped with Ubuntu Precise, for example, which is an LTS
release not yet out of its support period.)

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Message-id: 1452604204-27202-1-git-send-email-peter.maydell@linaro.org
Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
parent cf57c2f1

disas/Makefile.objs

+4 −1
Original line number Diff line number Diff line
@@ -4,7 +4,10 @@ common-obj-$(CONFIG_ARM_DIS) += arm.o 
common-obj-$(CONFIG_ARM_A64_DIS) += arm-a64.o

common-obj-$(CONFIG_ARM_A64_DIS) += libvixl/

libvixldir = $(SRC_PATH)/disas/libvixl

arm-a64.o-cflags := -I$(libvixldir)

# The -Wno-sign-compare is needed only for gcc 4.6, which complains about

# some signed-unsigned equality comparisons in libvixl which later gcc

# versions do not.

arm-a64.o-cflags := -I$(libvixldir) -Wno-sign-compare

common-obj-$(CONFIG_CRIS_DIS) += cris.o

common-obj-$(CONFIG_HPPA_DIS) += hppa.o

common-obj-$(CONFIG_I386_DIS) += i386.o

disas/libvixl/Makefile.objs

+3 −1
Original line number Diff line number Diff line
@@ -4,6 +4,8 @@ libvixl_OBJS = vixl/utils.o \ 
               vixl/a64/decoder-a64.o \

               vixl/a64/disasm-a64.o



$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl $(QEMU_CFLAGS)

# The -Wno-sign-compare is needed only for gcc 4.6, which complains about

# some signed-unsigned equality comparisons which later gcc versions do not.

$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl -Wno-sign-compare $(QEMU_CFLAGS)



common-obj-$(CONFIG_ARM_A64_DIS) += $(libvixl_OBJS)