Commit 8a9c1b77 authored by Thomas Huth's avatar Thomas Huth Committed by David Gibson
Browse files

hw/ppc/spapr: Halt CPU when powering off via RTAS call 



The LoPAPR specification defines the following for the RTAS
power-off call: "On successful operation, does not return".
However, the implementation in QEMU currently returns and runs
the guest CPU again for some more cycles. This caused some
trouble with the new ppc implementation of the kvm-unit-tests
recently. So let's make sure that the QEMU implementation
follows the spec, thus stop the CPU to make sure that the
RTAS call does not return to the guest anymore.

Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Tested-by: default avatarAndrew Jones <drjones@redhat.com>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 1c81003a

hw/ppc/spapr_rtas.c

+1 −0
Original line number Diff line number Diff line
@@ -113,6 +113,7 @@ static void rtas_power_off(PowerPCCPU *cpu, sPAPRMachineState *spapr, 
        return;

    }

    qemu_system_shutdown_request();

    cpu_stop_current();

    rtas_st(rets, 0, RTAS_OUT_SUCCESS);

}