Commit 89aa0d87 authored by Vladimir Sementsov-Ogievskiy's avatar Vladimir Sementsov-Ogievskiy Committed by Eric Blake
Browse files

nbd/client: fix nbd_negotiate_simple_meta_context 



Initialize received variable. Otherwise, is is possible for server to
answer without any contexts, but we will set context_id to something
random (received_id is not initialized too) and return 1, which is
wrong.

To solve it, just initialize received to false. Initialize received_id
too, just to make all possible checkers happy.

Bug was introduced in 78a33ab5 "nbd: BLOCK_STATUS for
standard get_block_status function: client part" with the whole
function.

Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20180427142002.21930-2-vsementsov@virtuozzo.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
CC: qemu-stable@nongnu.org
Signed-off-by: default avatarEric Blake <eblake@redhat.com>
parent 26bd8d98

nbd/client.c

+2 −2
Original line number Diff line number Diff line
@@ -613,8 +613,8 @@ static int nbd_negotiate_simple_meta_context(QIOChannel *ioc, 
{

    int ret;

    NBDOptionReply reply;

    uint32_t received_id;

    bool received;

    uint32_t received_id = 0;

    bool received = false;

    uint32_t export_len = strlen(export);

    uint32_t context_len = strlen(context);

    uint32_t data_len = sizeof(export_len) + export_len +