Commit 8983e3e3 authored by Tina Zhang's avatar Tina Zhang Committed by Gerd Hoffmann
Browse files

ui: introduce vfio_display_reset 



During guest OS reboot, guest framebuffer is invalid. It will cause
bugs, if the invalid guest framebuffer is still used by host.

This patch is to introduce vfio_display_reset which is invoked
during vfio display reset. This vfio_display_reset function is used
to release the invalid display resource, disable scanout mode and
replace the invalid surface with QemuConsole's DisplaySurafce.

This patch can fix the GPU hang issue caused by gd_egl_draw during
guest OS reboot.

Changes v3->v4:
 - Move dma-buf based display check into the vfio_display_reset().
   (Gerd)

Changes v2->v3:
 - Limit vfio_display_reset to dma-buf based vfio display. (Gerd)

Changes v1->v2:
 - Use dpy_gfx_update_full() update screen after reset. (Gerd)
 - Remove dpy_gfx_switch_surface(). (Gerd)

Signed-off-by: default avatarTina Zhang <tina.zhang@intel.com>
Message-id: 1524820266-27079-3-git-send-email-tina.zhang@intel.com
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 7cd0afe6

hw/vfio/display.c

+11 −0
Original line number Diff line number Diff line
@@ -198,6 +198,17 @@ static void vfio_display_dmabuf_exit(VFIODisplay *dpy) 
}



/* ---------------------------------------------------------------------- */

void vfio_display_reset(VFIOPCIDevice *vdev)

{

    if (!vdev || !vdev->dpy || !vdev->dpy->con ||

        !vdev->dpy->dmabuf.primary) {

        return;

    }



    dpy_gl_scanout_disable(vdev->dpy->con);

    vfio_display_dmabuf_exit(vdev->dpy);

    dpy_gfx_update_full(vdev->dpy->con);

}



static void vfio_display_region_update(void *opaque)

{

hw/vfio/pci.c

+4 −0
Original line number Diff line number Diff line
@@ -3103,6 +3103,10 @@ static void vfio_pci_reset(DeviceState *dev) 


    vfio_pci_pre_reset(vdev);



    if (vdev->display != ON_OFF_AUTO_OFF) {

        vfio_display_reset(vdev);

    }



    if (vdev->resetfn && !vdev->resetfn(vdev)) {

        goto post_reset;

    }

hw/vfio/pci.h

+1 −0
Original line number Diff line number Diff line
@@ -176,6 +176,7 @@ int vfio_pci_igd_opregion_init(VFIOPCIDevice *vdev, 
                               struct vfio_region_info *info,

                               Error **errp);



void vfio_display_reset(VFIOPCIDevice *vdev);

int vfio_display_probe(VFIOPCIDevice *vdev, Error **errp);

void vfio_display_finalize(VFIOPCIDevice *vdev);