Commit 88f9d1b3 authored by Kevin Wolf's avatar Kevin Wolf
Browse files

mirror: Fix error path for dirty bitmap creation 



mirror_top_bs must be removed from the graph again when creating the
dirty bitmap fails.

Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Reviewed-by: default avatarFam Zheng <famz@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
parent 0bf74767

block/mirror.c

+1 −4
Original line number Diff line number Diff line
@@ -1197,10 +1197,7 @@ static void mirror_start_job(const char *job_id, BlockDriverState *bs, 


    s->dirty_bitmap = bdrv_create_dirty_bitmap(bs, granularity, NULL, errp);

    if (!s->dirty_bitmap) {

        g_free(s->replaces);

        blk_unref(s->target);

        block_job_unref(&s->common);

        return;

        goto fail;

    }



    /* Required permissions are already taken with blk_new() */