Commit 88c1ee73 authored by Peter Crosthwaite's avatar Peter Crosthwaite Committed by Michael Tokarev
Browse files

char/serial: Fix emptyness check 



This was guarding against a full fifo rather than an empty fifo when
popping. Fix.

Signed-off-by: default avatarPeter Crosthwaite <peter.crosthwaite@xilinx.com>
Reviewed-by: default avatarMartin Kletzander <mkletzan@redhat.com>
Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent 5556332a

hw/char/serial.c

+1 −1
Original line number Diff line number Diff line
@@ -225,7 +225,7 @@ static gboolean serial_xmit(GIOChannel *chan, GIOCondition cond, void *opaque) 


    if (s->tsr_retry <= 0) {

        if (s->fcr & UART_FCR_FE) {

            s->tsr = fifo8_is_full(&s->xmit_fifo) ?

            s->tsr = fifo8_is_empty(&s->xmit_fifo) ?

                        0 : fifo8_pop(&s->xmit_fifo);

            if (!s->xmit_fifo.num) {

                s->lsr |= UART_LSR_THRE;