Commit 88552b16 authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Eduardo Habkost
Browse files

hw/misc/vmcoreinfo: Add comment about reset handler 



The VM coreinfo device does not sit on a bus, so it won't be
reset automatically. This is why it calls qemu_register_reset().

Add a comment about it, so we don't convert its reset handler
to a DeviceReset method.

Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: default avatarLi Qiang <liq3ea@gmail.com>
Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20191010131527.32513-9-philmd@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent f7030d00

hw/misc/vmcoreinfo.c

+4 −0
Original line number Diff line number Diff line
@@ -61,6 +61,10 @@ static void vmcoreinfo_realize(DeviceState *dev, Error **errp) 
                             NULL, fw_cfg_vmci_write, s,

                             &s->vmcoreinfo, sizeof(s->vmcoreinfo), false);



    /*

     * This device requires to register a global reset because it is

     * not plugged to a bus (which, as its QOM parent, would reset it).

     */

    qemu_register_reset(vmcoreinfo_reset, dev);

    vmcoreinfo_state = s;

}