Commit 8800cf0a authored by Leonid Bloch's avatar Leonid Bloch Committed by Paolo Bonzini
Browse files

checkpatch: Eliminate false positive in case of space before square bracket in a definition 



Now, macro definition such as "#define abc(x) [x] = y" should pass
without an error.

Signed-off-by: default avatarLeonid Bloch <leonid@daynix.com>
Message-Id: <1446112118-12376-3-git-send-email-leonid@daynix.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 409db6eb

scripts/checkpatch.pl

+2 −0
Original line number Diff line number Diff line
@@ -1716,11 +1716,13 @@ sub process { 
#  2. at the beginning of a line for slice initialisers -- [0...10] = 5,

#  3. inside a curly brace -- = { [0...10] = 5 }

#  4. after a comma -- [1] = 5, [2] = 6

#  5. in a macro definition -- #define abc(x) [x] = y

		while ($line =~ /(.*?\s)\[/g) {

			my ($where, $prefix) = ($-[1], $1);

			if ($prefix !~ /$Type\s+$/ &&

			    ($where != 0 || $prefix !~ /^.\s+$/) &&

			    $prefix !~ /{\s+$/ &&

			    $prefix !~ /\#\s*define[^(]*\([^)]*\)\s+$/ &&

			    $prefix !~ /,\s+$/) {

				ERROR("space prohibited before open square bracket '['\n" . $herecurr);

			}