Commit 8679638b authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Juan Quintela
Browse files

postcopy: Check for shared memory 



Postcopy doesn't support migration of RAM shared with another process
yet (we've got a bunch of things to understand).
Check for the case and don't allow postcopy to be enabled.

Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: default avatarJuan Quintela <quintela@redhat.com>
Signed-off-by: default avatarJuan Quintela <quintela@redhat.com>
parent 463a4ac2

migration/postcopy-ram.c

+18 −0
Original line number Diff line number Diff line
@@ -95,6 +95,19 @@ static bool ufd_version_check(int ufd) 
    return true;

}



/* Callback from postcopy_ram_supported_by_host block iterator.

 */

static int test_range_shared(const char *block_name, void *host_addr,

                             ram_addr_t offset, ram_addr_t length, void *opaque)

{

    if (qemu_ram_is_shared(qemu_ram_block_by_name(block_name))) {

        error_report("Postcopy on shared RAM (%s) is not yet supported",

                     block_name);

        return 1;

    }

    return 0;

}



/*

 * Note: This has the side effect of munlock'ing all of RAM, that's

 * normally fine since if the postcopy succeeds it gets turned back on at the
@@ -127,6 +140,11 @@ bool postcopy_ram_supported_by_host(void) 
        goto out;

    }



    /* We don't support postcopy with shared RAM yet */

    if (qemu_ram_foreach_block(test_range_shared, NULL)) {

        goto out;

    }



    /*

     * userfault and mlock don't go together; we'll put it back later if

     * it was enabled.