Commit 84c26520 authored by Max Reitz's avatar Max Reitz
Browse files

qcow2: Avoid making the L1 table too big 



We refuse to open images whose L1 table we deem "too big". Consequently,
we should not produce such images ourselves.

Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Message-id: 20160615153630.2116-3-mreitz@redhat.com
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
[mreitz: Added QEMU_BUILD_BUG_ON()]
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent bcf23482

block/qcow2-cluster.c

+2 −1
Original line number Diff line number Diff line
@@ -65,7 +65,8 @@ int qcow2_grow_l1_table(BlockDriverState *bs, uint64_t min_size, 
        }

    }



    if (new_l1_size > INT_MAX / sizeof(uint64_t)) {

    QEMU_BUILD_BUG_ON(QCOW_MAX_L1_SIZE > INT_MAX);

    if (new_l1_size > QCOW_MAX_L1_SIZE / sizeof(uint64_t)) {

        return -EFBIG;

    }