Commit 83f71802 authored Feb 21, 2019 by Marc-André Lureau Committed by Gerd Hoffmann Feb 21, 2019

spice: avoid spice runtime assert



The Spice server doesn't like to be started or stopped twice . It
aborts with:

(process:6191): Spice-ERROR **: 19:29:35.912: red-worker.c:623:handle_dev_start: assertion `!worker->running' failed

It's easy to avoid that situation since qemu spice_display_is_running
tracks the server state.

After the commit "spice: do not stop spice if VM is paused", it will
be possible to pause and resume the VM, and this will call
qemu_spice_display_start() twice. The easiest is to add a check for
spice_display_is_running with this patch to avoid the assert.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Tested-by: Victor Toso <victortoso@redhat.com>
Message-id: 20190221110703.5775-4-marcandre.lureau@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

parent a2dc3c8e

ui/spice-core.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -972,12 +972,20 @@ int qemu_spice_display_add_client(int csock, int skipauth, int tls)

		void qemu_spice_display_start(void)
		{
		if (spice_display_is_running) {
		return;
		}

		spice_display_is_running = true;
		spice_server_vm_start(spice_server);
		}

		void qemu_spice_display_stop(void)
		{
		if (!spice_display_is_running) {
		return;
		}

		spice_server_vm_stop(spice_server);
		spice_display_is_running = false;
		}