Commit 835cab85 authored by Christophe Fergeau's avatar Christophe Fergeau Committed by Gerd Hoffmann
Browse files

spice: abort on invalid streaming cmdline params 



When parsing its command line parameters, spice aborts when it
finds unexpected values, except for the 'streaming-video' option.
This happens because the parsing of the parameters for this option
is done using the 'name2enum' helper, which does not error out
on unknown values. Using the 'parse_name' helper makes sure we
error out in this case. Looking at git history, the use of
'name2enum' instead of 'parse_name' seems to have been an oversight,
so let's change to that now.

Fixes rhbz#831708

Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 8db972cf

ui/spice-core.c

+2 −1
Original line number Diff line number Diff line
@@ -344,7 +344,8 @@ static const char *stream_video_names[] = { 
    [ SPICE_STREAM_VIDEO_FILTER ] = "filter",

};

#define parse_stream_video(_name) \

    name2enum(_name, stream_video_names, ARRAY_SIZE(stream_video_names))

    parse_name(_name, "stream video control", \

               stream_video_names, ARRAY_SIZE(stream_video_names))



static const char *compression_names[] = {

    [ SPICE_IMAGE_COMPRESS_OFF ]      = "off",