Commit 82d07945 authored Feb 26, 2014 by Markus Armbruster Committed by Alex Williamson Feb 26, 2014

pci-assign: Fix potential read beyond buffer on -EBUSY



readlink() doesn't write a terminating null byte.
assign_failed_examine() passes the unterminated string to strrchr().
Oops.  Terminate it.

Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

parent 13665a2d

hw/i386/kvm/pci-assign.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -743,6 +743,7 @@ static void assign_failed_examine(AssignedDevice *dev)
		goto fail;
		}

		driver[r] = 0;
		ns = strrchr(driver, '/');
		if (!ns) {
		goto fail;