Commit 82c4f87e authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Stefan Hajnoczi
Browse files

trace: Fix format string for the struct timeval members casted to size_t 



This fixes when using GCC with -Wformat-signedness:

    migration/trace.h: In function ‘_nocheck__trace_dirty_bitmap_load_success’:
    migration/trace.h:6368:24: error: format ‘%zd’ expects argument of type ‘signed size_t’, but argument 3 has type ‘long unsigned int’ [-Werror=format=]
      qemu_log("%d@%zd.%06zd:dirty_bitmap_load_success " "" "\n",
                   ~~^
                   %ld
    migration/trace.h:6370:18:
               (size_t)_now.tv_sec, (size_t)_now.tv_usec
               ~~~~~~~~~~~~~~~~~~~
    migration/trace.h:6368:30: error: format ‘%zd’ expects argument of type ‘signed size_t’, but argument 4 has type ‘long unsigned int’ [-Werror=format=]
      qemu_log("%d@%zd.%06zd:dirty_bitmap_load_success " "" "\n",
                       ~~~~^
                       %06ld
    migration/trace.h:6370:39:
               (size_t)_now.tv_sec, (size_t)_now.tv_usec
                                    ~~~~~~~~~~~~~~~~~~~~

Signed-off-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 749c1d8e

scripts/tracetool/backend/log.py

+1 −1
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ def generate_h(event, group): 
    out('    if (%(cond)s && qemu_loglevel_mask(LOG_TRACE)) {',

        '        struct timeval _now;',

        '        gettimeofday(&_now, NULL);',

        '        qemu_log("%%d@%%zd.%%06zd:%(name)s " %(fmt)s "\\n",',

        '        qemu_log("%%d@%%zu.%%06zu:%(name)s " %(fmt)s "\\n",',

        '                 getpid(),',

        '                 (size_t)_now.tv_sec, (size_t)_now.tv_usec',

        '                 %(argnames)s);',