Commit 8140e786 authored by Fabiano Rosas's avatar Fabiano Rosas Committed by Kevin Wolf
Browse files

block/blkreplay: Remove protocol-related fields 



The blkreplay driver is not a protocol so it should implement bdrv_open
instead of bdrv_file_open and not provide a protocol_name.

Attempts to invoke this driver using protocol syntax
(i.e. blkreplay:<filename:options:...>) will now fail gracefully:

  $ qemu-img info blkreplay:foo
  qemu-img: Could not open 'blkreplay:foo': Unknown protocol 'blkreplay'

Signed-off-by: default avatarFabiano Rosas <farosas@linux.vnet.ibm.com>
Reviewed-by: default avatarPavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent a7328ba5

block/blkreplay.c

+1 −2
Original line number Diff line number Diff line
@@ -129,10 +129,9 @@ static int coroutine_fn blkreplay_co_flush(BlockDriverState *bs) 


static BlockDriver bdrv_blkreplay = {

    .format_name            = "blkreplay",

    .protocol_name          = "blkreplay",

    .instance_size          = 0,



    .bdrv_file_open         = blkreplay_open,

    .bdrv_open              = blkreplay_open,

    .bdrv_close             = blkreplay_close,

    .bdrv_child_perm        = bdrv_filter_default_perms,

    .bdrv_getlength         = blkreplay_getlength,