Commit 80d2b933 authored Mar 05, 2018 by Paolo Bonzini

openpic_kvm: drop address_space_to_flatview call



The MemoryListener is registered on address_space_memory, there is
not much to assert.  This currently works because the callback
is invoked only once when the listener is registered, but section->fv
is the _new_ FlatView, not the old one on later calls and that
would break.

This confines address_space_to_flatview to exec.c and memory.c.

Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent 8b2ec54f

hw/intc/openpic_kvm.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -125,10 +125,6 @@ static void kvm_openpic_region_add(MemoryListener *listener,
		uint64_t reg_base;
		int ret;

		if (section->fv != address_space_to_flatview(&address_space_memory)) {
		abort();
		}

		/* Ignore events on regions that are not us */
		if (section->mr != &opp->mem) {
		return;