Commit 80aab795 authored by Laurent Vivier's avatar Laurent Vivier
Browse files

q800: fix coverity warning CID 1412799 



Check the return value of blk_write() and log an error if any

Fixes: Coverity CID 1412799 (Error handling issues)
Signed-off-by: default avatarLaurent Vivier <laurent@vivier.eu>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200210132252.381343-1-laurent@vivier.eu>
parent 104933c4

hw/misc/mac_via.c

+5 −2
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ 
#include "hw/qdev-properties.h"

#include "sysemu/block-backend.h"

#include "trace.h"

#include "qemu/log.h"



/*

 * VIAs: There are two in every machine,
@@ -381,8 +382,10 @@ static void via2_irq_request(void *opaque, int irq, int level) 
static void pram_update(MacVIAState *m)

{

    if (m->blk) {

        blk_pwrite(m->blk, 0, m->mos6522_via1.PRAM,

                   sizeof(m->mos6522_via1.PRAM), 0);

        if (blk_pwrite(m->blk, 0, m->mos6522_via1.PRAM,

                       sizeof(m->mos6522_via1.PRAM), 0) < 0) {

            qemu_log("pram_update: cannot write to file\n");

        }

    }

}