Commit 8064af6b authored by David Hildenbrand's avatar David Hildenbrand Committed by Cornelia Huck
Browse files

s390x/mmu: Remove duplicate check for MMU_DATA_STORE 



No need to double-check if we have a write.

Found by Coverity (CID: 1406404).

Fixes: 31b59419 ("target/s390x: Return exception from mmu_translate_real")
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Message-Id: <20191017121922.18840-1-david@redhat.com>
Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
parent be39110d

target/s390x/mmu_helper.c

+1 −3
Original line number Diff line number Diff line
@@ -556,9 +556,7 @@ int mmu_translate_real(CPUS390XState *env, target_ulong raddr, int rw, 
        *flags |= PAGE_WRITE_INV;

        if (is_low_address(raddr) && rw == MMU_DATA_STORE) {

            /* LAP sets bit 56 */

            *tec = (raddr & TARGET_PAGE_MASK)

                 | (rw == MMU_DATA_STORE ? FS_WRITE : FS_READ)

                 | 0x80;

            *tec = (raddr & TARGET_PAGE_MASK) | FS_WRITE | 0x80;

            return PGM_PROTECTION;

        }

    }