Commit 80313fb5 authored by Markus Armbruster's avatar Markus Armbruster
Browse files

error: Drop bogus "use error_setg() instead" admonitions 



Commit 97f40301 "error: Functions to report warnings and
informational messages" copied the "use error_setg() instead"
admonition from the error reporting functions to new functions even
though it doesn't actually apply there.  Drop it.  Also drop it from
vreport(), where it doesn't apply anymore.

Reported-by: default avatarKevin Wolf <kwolf@redhat.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Message-Id: <20181019123923.26649-1-armbru@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
parent 04788ba2

util/qemu-error.c

+0 −5
Original line number Diff line number Diff line
@@ -194,7 +194,6 @@ bool enable_timestamp_msg; 
 * Format arguments like vsprintf().  The resulting message should be

 * a single phrase, with no newline or trailing punctuation.

 * Prepend the current location and append a newline.

 * It's wrong to call this in a QMP monitor.  Use error_setg() there.

 */

static void vreport(report_type type, const char *fmt, va_list ap)

{
@@ -242,7 +241,6 @@ void error_vreport(const char *fmt, va_list ap) 
 * Format arguments like vsprintf().  The resulting message should be

 * a single phrase, with no newline or trailing punctuation.

 * Prepend the current location and append a newline.

 * It's wrong to call this in a QMP monitor.  Use error_setg() there.

 */

void warn_vreport(const char *fmt, va_list ap)

{
@@ -255,7 +253,6 @@ void warn_vreport(const char *fmt, va_list ap) 
 * Format arguments like vsprintf().  The resulting message should be

 * a single phrase, with no newline or trailing punctuation.

 * Prepend the current location and append a newline.

 * It's wrong to call this in a QMP monitor.  Use error_setg() there.

 */

void info_vreport(const char *fmt, va_list ap)

{
@@ -283,7 +280,6 @@ void error_report(const char *fmt, ...) 
 * Format arguments like sprintf(). The resulting message should be a

 * single phrase, with no newline or trailing punctuation.

 * Prepend the current location and append a newline.

 * It's wrong to call this in a QMP monitor.  Use error_setg() there.

 */

void warn_report(const char *fmt, ...)

{
@@ -300,7 +296,6 @@ void warn_report(const char *fmt, ...) 
 * Format arguments like sprintf(). The resulting message should be a

 * single phrase, with no newline or trailing punctuation.

 * Prepend the current location and append a newline.

 * It's wrong to call this in a QMP monitor.  Use error_setg() there.

 */

void info_report(const char *fmt, ...)

{