Commit 7f9136f9 authored by Cédric Le Goater's avatar Cédric Le Goater Committed by David Gibson
Browse files

spapr/xive: EQ page should be naturally aligned 



When the OS configures the EQ page in which to receive event
notifications from the XIVE interrupt controller, the page should be
naturally aligned. Add this check.

Signed-off-by: default avatarCédric Le Goater <clg@kaod.org>
Message-Id: <20190508171946.657-2-clg@kaod.org>
Reviewed-by: default avatarGreg Kurz <groug@kaod.org>
[dwg: Minor change for printf warning on some platforms]
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 4c406ca7

hw/intc/spapr_xive.c

+6 −0
Original line number Diff line number Diff line
@@ -993,6 +993,12 @@ static target_ulong h_int_set_queue_config(PowerPCCPU *cpu, 
    case 16:

    case 21:

    case 24:

        if (!QEMU_IS_ALIGNED(qpage, 1ul << qsize)) {

            qemu_log_mask(LOG_GUEST_ERROR, "XIVE: EQ @0x%" HWADDR_PRIx

                          " is not naturally aligned with %" HWADDR_PRIx "\n",

                          qpage, (hwaddr)1 << qsize);

            return H_P4;

        }

        end.w2 = cpu_to_be32((qpage >> 32) & 0x0fffffff);

        end.w3 = cpu_to_be32(qpage & 0xffffffff);

        end.w0 |= cpu_to_be32(END_W0_ENQUEUE);