Commit 7f87af39 authored by Markus Armbruster's avatar Markus Armbruster Committed by Anthony Liguori
Browse files

pc_sysfw: Fix ISA BIOS init for ridiculously big flash 



pc_isa_bios_init() suffers integer overflow for flash larger than
INT_MAX.

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Acked-by: default avatarLaszlo Ersek <lersek@redhat.com>
Acked-by: default avatarStefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
Message-id: 1375276272-15988-9-git-send-email-armbru@redhat.com
Signed-off-by: default avatarAnthony Liguori <anthony@codemonkey.ws>
parent 39228250

hw/i386/pc_sysfw.c

+1 −4
Original line number Diff line number Diff line
@@ -53,10 +53,7 @@ static void pc_isa_bios_init(MemoryRegion *rom_memory, 
    flash_size = memory_region_size(flash_mem);



    /* map the last 128KB of the BIOS in ISA space */

    isa_bios_size = flash_size;

    if (isa_bios_size > (128 * 1024)) {

        isa_bios_size = 128 * 1024;

    }

    isa_bios_size = MIN(flash_size, 128 * 1024);

    isa_bios = g_malloc(sizeof(*isa_bios));

    memory_region_init_ram(isa_bios, NULL, "isa-bios", isa_bios_size);

    vmstate_register_ram_global(isa_bios);