Commit 7f5d9b20 authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

object-add: don't create return value if failed 



No need to return an empty value from object-add (it would also leak
if the command failed).  While at it, remove the "if" around object_unref
since object_unref handles NULL arguments just fine.

Reported-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200325184723.2029630-4-marcandre.lureau@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent b3fbb328

qom/qom-qmp-cmds.c

+1 −4
Original line number Diff line number Diff line
@@ -285,11 +285,8 @@ void qmp_object_add(QDict *qdict, QObject **ret_data, Error **errp) 
    v = qobject_input_visitor_new(QOBJECT(qdict));

    obj = user_creatable_add_type(type, id, qdict, v, errp);

    visit_free(v);

    if (obj) {

    object_unref(obj);

}

    *ret_data = QOBJECT(qdict_new());

}



void qmp_object_del(const char *id, Error **errp)

{