Commit 7ec81e56 authored by David Gibson's avatar David Gibson Committed by Anthony Liguori
Browse files

Fix off-by-1 error in RAM migration code 



The code for migrating (or savevm-ing) memory pages starts off by creating
a dirty bitmap and filling it with 1s.  Except, actually, because bit
addresses are 0-based it fills every bit except bit 0 with 1s and puts an
extra 1 beyond the end of the bitmap, potentially corrupting unrelated
memory.  Oops.  This patch fixes it.

Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
parent 1c97e303

arch_init.c

+1 −1
Original line number Diff line number Diff line
@@ -568,7 +568,7 @@ static int ram_save_setup(QEMUFile *f, void *opaque) 
    int64_t ram_pages = last_ram_offset() >> TARGET_PAGE_BITS;



    migration_bitmap = bitmap_new(ram_pages);

    bitmap_set(migration_bitmap, 1, ram_pages);

    bitmap_set(migration_bitmap, 0, ram_pages);

    migration_dirty_pages = ram_pages;



    bytes_transferred = 0;