Commit 7e17d50e authored by Richard Henderson's avatar Richard Henderson Committed by Peter Maydell
Browse files

target/arm: Fix tcg_gen_gvec_dup_imm vs DUP (indexed) 



DUP (indexed) can duplicate 128-bit elements, so using esz
unconditionally can assert in tcg_gen_gvec_dup_imm.

Fixes: 8711e71f
Reported-by: default avatarLaurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Reviewed-by: default avatarLaurent Desnogues <laurent.desnogues@gmail.com>
Tested-by: default avatarLaurent Desnogues <laurent.desnogues@gmail.com>
Message-id: 20200507172352.15418-5-richard.henderson@linaro.org
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 08975da9

target/arm/translate-sve.c

+5 −1
Original line number Diff line number Diff line
@@ -2044,7 +2044,11 @@ static bool trans_DUP_x(DisasContext *s, arg_DUP_x *a) 
            unsigned nofs = vec_reg_offset(s, a->rn, index, esz);

            tcg_gen_gvec_dup_mem(esz, dofs, nofs, vsz, vsz);

        } else {

            tcg_gen_gvec_dup_imm(esz, dofs, vsz, vsz, 0);

            /*

             * While dup_mem handles 128-bit elements, dup_imm does not.

             * Thankfully element size doesn't matter for splatting zero.

             */

            tcg_gen_gvec_dup_imm(MO_64, dofs, vsz, vsz, 0);

        }

    }

    return true;