Commit 7d81c141 authored by Stefan Hajnoczi's avatar Stefan Hajnoczi Committed by Kevin Wolf
Browse files

block: refuse negative iops and bps values 



Negative I/O throttling iops and bps values do not make sense so reject
them with an error message.

Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent c546194f

blockdev.c

+10 −0
Original line number Diff line number Diff line
@@ -274,6 +274,16 @@ static bool do_check_io_limits(BlockIOLimit *io_limits, Error **errp) 
        return false;

    }



    if (io_limits->bps[BLOCK_IO_LIMIT_TOTAL] < 0 ||

        io_limits->bps[BLOCK_IO_LIMIT_WRITE] < 0 ||

        io_limits->bps[BLOCK_IO_LIMIT_READ] < 0 ||

        io_limits->iops[BLOCK_IO_LIMIT_TOTAL] < 0 ||

        io_limits->iops[BLOCK_IO_LIMIT_WRITE] < 0 ||

        io_limits->iops[BLOCK_IO_LIMIT_READ] < 0) {

        error_setg(errp, "bps and iops values must be 0 or greater");

        return false;

    }



    return true;

}