Commit 7b8a8474 authored by Pankaj Gupta's avatar Pankaj Gupta Committed by Michael S. Tsirkin
Browse files

virtio pmem: remove memdev null check 



Coverity reports that when we're assigning vi->size we handle the
"pmem->memdev is NULL" case; but we then pass it into
object_get_canonical_path(), which unconditionally dereferences it
and will crash if it is NULL. If this pointer can be NULL then we
need to do something else here.

We are removing 'pmem->memdev' null check here as memdev will never
be null in this function.

Signed-off-by: default avatarPankaj Gupta <pagupta@redhat.com>
Message-Id: <20190712073554.21918-3-pagupta@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarCornelia Huck <cohuck@redhat.com>
parent f37f4712

hw/virtio/virtio-pmem.c

+2 −2
Original line number Diff line number Diff line
@@ -134,7 +134,7 @@ static void virtio_pmem_fill_device_info(const VirtIOPMEM *pmem, 
                                         VirtioPMEMDeviceInfo *vi)

{

    vi->memaddr = pmem->start;

    vi->size = pmem->memdev ? memory_region_size(&pmem->memdev->mr) : 0;

    vi->size    = memory_region_size(&pmem->memdev->mr);

    vi->memdev  = object_get_canonical_path(OBJECT(pmem->memdev));

}