Commit 7aab5899 authored by David Gibson's avatar David Gibson
Browse files

spapr: Fix failure path for attempting to hot unplug PCI bridges 



For various technical reasons we can't currently allow unplug a PCI to PCI
bridge on the pseries machine.  spapr_pci_unplug_request() correctly
generates an error message if that's attempted.

But.. if the given errp is not error_abort or error_fatal, it doesn't
actually stop trying to unplug the bridge anyway.

Fixes: 14e71490 "spapr: Allow hot plug/unplug of PCI bridges and devices under PCI bridges"
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Reviewed-by: default avatarGreg Kurz <groug@kaod.org>
parent 4f7a11f9

hw/ppc/spapr_pci.c

+1 −0
Original line number Diff line number Diff line
@@ -1663,6 +1663,7 @@ static void spapr_pci_unplug_request(HotplugHandler *plug_handler, 


        if (pc->is_bridge) {

            error_setg(errp, "PCI: Hot unplug of PCI bridges not supported");

            return;

        }



        /* ensure any other present functions are pending unplug */