Commit 7a309cc9 authored by Markus Armbruster's avatar Markus Armbruster
Browse files

qom: Change object_get_canonical_path_component() not to malloc 



object_get_canonical_path_component() returns a malloced copy of a
property name on success, null on failure.

19 of its 25 callers immediately free the returned copy.

Change object_get_canonical_path_component() to return the property
name directly.  Since modifying the name would be wrong, adjust the
return type to const char *.

Drop the free from the 19 callers become simpler, add the g_strdup()
to the other six.

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Message-Id: <20200714160202.3121879-4-armbru@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarLi Qiang <liq3ea@gmail.com>
parent af3d6905

backends/hostmem.c

+1 −1
Original line number Diff line number Diff line
@@ -33,7 +33,7 @@ char * 
host_memory_backend_get_name(HostMemoryBackend *backend)

{

    if (!backend->use_canonical_path) {

        return object_get_canonical_path_component(OBJECT(backend));

        return g_strdup(object_get_canonical_path_component(OBJECT(backend)));

    }



    return object_get_canonical_path(OBJECT(backend));

block/throttle-groups.c

+1 −1
Original line number Diff line number Diff line
@@ -771,7 +771,7 @@ static void throttle_group_obj_complete(UserCreatable *obj, Error **errp) 


    /* set group name to object id if it exists */

    if (!tg->name && tg->parent_obj.parent) {

        tg->name = object_get_canonical_path_component(OBJECT(obj));

        tg->name = g_strdup(object_get_canonical_path_component(OBJECT(obj)));

    }

    /* We must have a group name at this point */

    assert(tg->name);

gdbstub.c

+1 −1
Original line number Diff line number Diff line
@@ -2059,7 +2059,7 @@ static void handle_query_thread_extra(GdbCmdContext *gdb_ctx, void *user_ctx) 
        /* Print the CPU model and name in multiprocess mode */

        ObjectClass *oc = object_get_class(OBJECT(cpu));

        const char *cpu_model = object_class_get_name(oc);

        g_autofree char *cpu_name =

        const char *cpu_name =

            object_get_canonical_path_component(OBJECT(cpu));

        g_string_printf(rs, "%s %s [%s]", cpu_model, cpu_name,

                        cpu->halted ? "halted " : "running");

hw/arm/xlnx-zynqmp.c

+2 −4
Original line number Diff line number Diff line
@@ -190,7 +190,7 @@ static void xlnx_zynqmp_create_rpu(MachineState *ms, XlnxZynqMPState *s, 
    qdev_prop_set_uint32(DEVICE(&s->rpu_cluster), "cluster-id", 1);



    for (i = 0; i < num_rpus; i++) {

        char *name;

        const char *name;



        object_initialize_child(OBJECT(&s->rpu_cluster), "rpu-cpu[*]",

                                &s->rpu_cpu[i],
@@ -204,7 +204,6 @@ static void xlnx_zynqmp_create_rpu(MachineState *ms, XlnxZynqMPState *s, 
        } else {

            s->boot_cpu_ptr = &s->rpu_cpu[i];

        }

        g_free(name);



        object_property_set_bool(OBJECT(&s->rpu_cpu[i]), "reset-hivecs", true,

                                 &error_abort);
@@ -341,7 +340,7 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp) 


    /* Realize APUs before realizing the GIC. KVM requires this.  */

    for (i = 0; i < num_apus; i++) {

        char *name;

        const char *name;



        object_property_set_int(OBJECT(&s->apu_cpu[i]), "psci-conduit",

                                QEMU_PSCI_CONDUIT_SMC, &error_abort);
@@ -354,7 +353,6 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp) 
        } else {

            s->boot_cpu_ptr = &s->apu_cpu[i];

        }

        g_free(name);



        object_property_set_bool(OBJECT(&s->apu_cpu[i]), "has_el3", s->secure,

                                 NULL);

hw/block/nvme.c

+2 −3
Original line number Diff line number Diff line
@@ -1397,9 +1397,8 @@ static void nvme_check_constraints(NvmeCtrl *n, Error **errp) 


    if (!n->params.cmb_size_mb && n->pmrdev) {

        if (host_memory_backend_is_mapped(n->pmrdev)) {

            char *path = object_get_canonical_path_component(OBJECT(n->pmrdev));

            error_setg(errp, "can't use already busy memdev: %s", path);

            g_free(path);

            error_setg(errp, "can't use already busy memdev: %s",

                       object_get_canonical_path_component(OBJECT(n->pmrdev)));

            return;

        }