Commit 79859507 authored Sep 28, 2015 by Eduardo Habkost Committed by Michael S. Tsirkin Oct 01, 2015

pc: Add a comment explaining why pc_compat_2_4() doesn't exist



pc_compat_2_4() doesn't exist, and we shouldn't create one. Add a
comment explaining why the function doesn't exist and why pc_compat_*()
functions are deprecated.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

parent 8561c924

hw/i386/pc_piix.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -301,6 +301,13 @@ static void pc_init1(MachineState *machine,
		}
		}

		/* Looking for a pc_compat_2_4() function? It doesn't exist.
		* pc_compat_*() functions that run on machine-init time and
		* change global QEMU state are deprecated. Please don't create
		* one, and implement any pc-*-2.4 (and newer) compat code in
		* HW_COMPAT_, PC_COMPAT_, or * pc_*_machine_options().
		*/

		static void pc_compat_2_3(MachineState *machine)
		{
		PCMachineState *pcms = PC_MACHINE(machine);

hw/i386/pc_q35.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -284,6 +284,13 @@ static void pc_q35_init(MachineState *machine)
		}
		}

		/* Looking for a pc_compat_2_4() function? It doesn't exist.
		* pc_compat_*() functions that run on machine-init time and
		* change global QEMU state are deprecated. Please don't create
		* one, and implement any pc-*-2.4 (and newer) compat code in
		* HW_COMPAT_, PC_COMPAT_, or * pc_*_machine_options().
		*/

		static void pc_compat_2_3(MachineState *machine)
		{
		PCMachineState *pcms = PC_MACHINE(machine);