Commit 7844e448 authored by Gerd Hoffmann's avatar Gerd Hoffmann
Browse files

qxl: don't render stuff when the vm is stopped. 



This patch fixes the local qxl renderer to not kick spice-server
in case the vm is stopped.  First it is largely pointless because
we ask spice-server to process all not-yet processed commands when
the vm is stopped, so there isn't much do do anyway.  Second we
avoid triggering an assert in spice-server.

The patch makes sure we still honor redraw requests, even if we don't
ask spice-server for updates.  This is needed to handle displaysurface
changes with a stopped vm correctly.

With this patch applied it is possible to take screen shots (via
screendump monitor command) from a qxl gpu even in case the guest
is stopped.

Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent f4a8a424

hw/qxl-render.c

+5 −7
Original line number Diff line number Diff line
@@ -121,19 +121,17 @@ void qxl_render_update(PCIQXLDevice *qxl) 
        dpy_resize(vga->ds);

    }



    if (!qxl->guest_primary.commands) {

        return;

    }

    qxl->guest_primary.commands = 0;



    update.left   = 0;

    update.right  = qxl->guest_primary.surface.width;

    update.top    = 0;

    update.bottom = qxl->guest_primary.surface.height;



    memset(dirty, 0, sizeof(dirty));

    if (runstate_is_running() && qxl->guest_primary.commands) {

        qxl->guest_primary.commands = 0;

        qxl_spice_update_area(qxl, 0, &update,

                              dirty, ARRAY_SIZE(dirty), 1, QXL_SYNC);

    }

    if (redraw) {

        memset(dirty, 0, sizeof(dirty));

        dirty[0] = update;