Commit 78113e83 authored by Richard Henderson's avatar Richard Henderson
Browse files

tcg: Return bool success from tcg_out_mov 



This patch merely changes the interface, aborting on all failures,
of which there are currently none.

Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
parent c16f52b2

tcg/aarch64/tcg-target.inc.c

+3 −2
Original line number Diff line number Diff line
@@ -938,10 +938,10 @@ static void tcg_out_ldst(TCGContext *s, AArch64Insn insn, TCGReg rd, 
    tcg_out_ldst_r(s, insn, rd, rn, TCG_TYPE_I64, TCG_REG_TMP);

}



static void tcg_out_mov(TCGContext *s, TCGType type, TCGReg ret, TCGReg arg)

static bool tcg_out_mov(TCGContext *s, TCGType type, TCGReg ret, TCGReg arg)

{

    if (ret == arg) {

        return;

        return true;

    }

    switch (type) {

    case TCG_TYPE_I32:
@@ -970,6 +970,7 @@ static void tcg_out_mov(TCGContext *s, TCGType type, TCGReg ret, TCGReg arg) 
    default:

        g_assert_not_reached();

    }

    return true;

}



static void tcg_out_ld(TCGContext *s, TCGType type, TCGReg ret,

tcg/arm/tcg-target.inc.c

+2 −1
Original line number Diff line number Diff line
@@ -2264,10 +2264,11 @@ static inline bool tcg_out_sti(TCGContext *s, TCGType type, TCGArg val, 
    return false;

}



static inline void tcg_out_mov(TCGContext *s, TCGType type,

static inline bool tcg_out_mov(TCGContext *s, TCGType type,

                               TCGReg ret, TCGReg arg)

{

    tcg_out_mov_reg(s, COND_AL, ret, arg);

    return true;

}



static inline void tcg_out_movi(TCGContext *s, TCGType type,

tcg/i386/tcg-target.inc.c

+3 −2
Original line number Diff line number Diff line
@@ -809,12 +809,12 @@ static inline void tgen_arithr(TCGContext *s, int subop, int dest, int src) 
    tcg_out_modrm(s, OPC_ARITH_GvEv + (subop << 3) + ext, dest, src);

}



static void tcg_out_mov(TCGContext *s, TCGType type, TCGReg ret, TCGReg arg)

static bool tcg_out_mov(TCGContext *s, TCGType type, TCGReg ret, TCGReg arg)

{

    int rexw = 0;



    if (arg == ret) {

        return;

        return true;

    }

    switch (type) {

    case TCG_TYPE_I64:
@@ -852,6 +852,7 @@ static void tcg_out_mov(TCGContext *s, TCGType type, TCGReg ret, TCGReg arg) 
    default:

        g_assert_not_reached();

    }

    return true;

}



static void tcg_out_dup_vec(TCGContext *s, TCGType type, unsigned vece,

tcg/mips/tcg-target.inc.c

+2 −1
Original line number Diff line number Diff line
@@ -558,13 +558,14 @@ static inline void tcg_out_dsra(TCGContext *s, TCGReg rd, TCGReg rt, TCGArg sa) 
    tcg_out_opc_sa64(s, OPC_DSRA, OPC_DSRA32, rd, rt, sa);

}



static inline void tcg_out_mov(TCGContext *s, TCGType type,

static inline bool tcg_out_mov(TCGContext *s, TCGType type,

                               TCGReg ret, TCGReg arg)

{

    /* Simple reg-reg move, optimising out the 'do nothing' case */

    if (ret != arg) {

        tcg_out_opc_reg(s, OPC_OR, ret, arg, TCG_REG_ZERO);

    }

    return true;

}



static void tcg_out_movi(TCGContext *s, TCGType type,

tcg/ppc/tcg-target.inc.c

+2 −1
Original line number Diff line number Diff line
@@ -559,12 +559,13 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type, 
static void tcg_out_mem_long(TCGContext *s, int opi, int opx, TCGReg rt,

                             TCGReg base, tcg_target_long offset);



static void tcg_out_mov(TCGContext *s, TCGType type, TCGReg ret, TCGReg arg)

static bool tcg_out_mov(TCGContext *s, TCGType type, TCGReg ret, TCGReg arg)

{

    tcg_debug_assert(TCG_TARGET_REG_BITS == 64 || type == TCG_TYPE_I32);

    if (ret != arg) {

        tcg_out32(s, OR | SAB(arg, ret, arg));

    }

    return true;

}



static inline void tcg_out_rld(TCGContext *s, int op, TCGReg ra, TCGReg rs,