Commit 77606363 authored by Daniel P. Berrangé's avatar Daniel P. Berrangé Committed by Stefan Hajnoczi
Browse files

trace: enforce that every trace-events file has a final newline 



When generating the trace-events-all file, the build system simply
concatenates all the individual trace-events files. If any one of those
files does not have a final newline, the printf format string will have
the contents of the first line of the next file appended to it, which is
usually a '#' comment.

Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
Message-id: 20190123120016.4538-3-berrange@redhat.com
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 00f42697

scripts/tracetool/__init__.py

+2 −0
Original line number Diff line number Diff line
@@ -350,6 +350,8 @@ def read_events(fobj, fname): 


    events = []

    for lineno, line in enumerate(fobj, 1):

        if line[-1] != '\n':

            raise ValueError("%s does not end with a new line" % fname)

        if not line.strip():

            continue

        if line.lstrip().startswith('#'):

hw/gpio/trace-events

+1 −1

File changed.

Contains only whitespace changes.