Commit 77302fb5 authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

memory: remove memory_region_test_and_clear_dirty 



It is unused after g364fb has been converted to use DirtyBitmapSnapshot.

Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent f7189ac8

include/exec/memory.h

+3 −21
Original line number Diff line number Diff line
@@ -1090,33 +1090,15 @@ bool memory_region_get_dirty(MemoryRegion *mr, hwaddr addr, 
void memory_region_set_dirty(MemoryRegion *mr, hwaddr addr,

                             hwaddr size);



/**

 * memory_region_test_and_clear_dirty: Check whether a range of bytes is dirty

 *                                     for a specified client. It clears them.

 *

 * Checks whether a range of bytes has been written to since the last

 * call to memory_region_reset_dirty() with the same @client.  Dirty logging

 * must be enabled.

 *

 * @mr: the memory region being queried.

 * @addr: the address (relative to the start of the region) being queried.

 * @size: the size of the range being queried.

 * @client: the user of the logging information; %DIRTY_MEMORY_MIGRATION or

 *          %DIRTY_MEMORY_VGA.

 */

bool memory_region_test_and_clear_dirty(MemoryRegion *mr, hwaddr addr,

                                        hwaddr size, unsigned client);



/**

 * memory_region_snapshot_and_clear_dirty: Get a snapshot of the dirty

 *                                         bitmap and clear it.

 *

 * Creates a snapshot of the dirty bitmap, clears the dirty bitmap and

 * returns the snapshot.  The snapshot can then be used to query dirty

 * status, using memory_region_snapshot_get_dirty.  Unlike

 * memory_region_test_and_clear_dirty this allows to query the same

 * page multiple times, which is especially useful for display updates

 * where the scanlines often are not page aligned.

 * status, using memory_region_snapshot_get_dirty.  Snapshotting allows

 * querying the same page multiple times, which is especially useful for

 * display updates where the scanlines often are not page aligned.

 *

 * The dirty bitmap region which gets copyed into the snapshot (and

 * cleared afterwards) can be larger than requested.  The boundaries

memory.c

+0 −8
Original line number Diff line number Diff line
@@ -1971,14 +1971,6 @@ void memory_region_set_dirty(MemoryRegion *mr, hwaddr addr, 
                                        memory_region_get_dirty_log_mask(mr));

}



bool memory_region_test_and_clear_dirty(MemoryRegion *mr, hwaddr addr,

                                        hwaddr size, unsigned client)

{

    assert(mr->ram_block);

    return cpu_physical_memory_test_and_clear_dirty(

                memory_region_get_ram_addr(mr) + addr, size, client);

}



DirtyBitmapSnapshot *memory_region_snapshot_and_clear_dirty(MemoryRegion *mr,

                                                            hwaddr addr,

                                                            hwaddr size,