Commit 77228373 authored by Halil Pasic's avatar Halil Pasic Committed by Cornelia Huck
Browse files

s390/ipl: fix off-by-one in update_machine_ipl_properties() 



In update_machine_ipl_properties() the array ascii_loadparm needs to
hold the 8 char loadparm and a string terminating zero char.

Let's increase the size of ascii_loadparm accordingly.

Signed-off-by: default avatarHalil Pasic <pasic@linux.ibm.com>
Fixes: 0a01e082 ("s390/ipl: sync back loadparm")
Fixes: Coverity CID 1421966
Reported-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Message-Id: <20200320143101.41764-1-pasic@linux.ibm.com>
Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
parent f58f084e

hw/s390x/ipl.c

+1 −1
Original line number Diff line number Diff line
@@ -546,7 +546,7 @@ static void update_machine_ipl_properties(IplParameterBlock *iplb) 
    /* Sync loadparm */

    if (iplb->flags & DIAG308_FLAGS_LP_VALID) {

        uint8_t *ebcdic_loadparm = iplb->loadparm;

        char ascii_loadparm[8];

        char ascii_loadparm[9];

        int i;



        for (i = 0; i < 8 && ebcdic_loadparm[i]; i++) {