Commit 75de5941 authored by Greg Kurz's avatar Greg Kurz Committed by David Gibson
Browse files

spapr: Print out extra hints when CAS negotiation of interrupt mode fails 



Let's suggest to the user how the machine should be configured to allow
the guest to boot successfully.

Suggested-by: default avatarSatheesh Rajendran <sathnaga@linux.vnet.ibm.com>
Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Message-Id: <155799221739.527449.14907564571096243745.stgit@bahia.lan>
Reviewed-by: default avatarSatheesh Rajendran <sathnaga@linux.vnet.ibm.com>
Tested-by: default avatarSatheesh Rajendran <sathnaga@linux.vnet.ibm.com>
[dwg: Adjusted for style error]
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent eb3cba82

hw/ppc/spapr_hcall.c

+4 −2
Original line number Diff line number Diff line
@@ -1646,12 +1646,14 @@ static target_ulong h_client_architecture_support(PowerPCCPU *cpu, 
     */

    if (guest_xive) {

        if (spapr->irq->ov5 == SPAPR_OV5_XIVE_LEGACY) {

            error_report("Guest requested unavailable interrupt mode (XIVE)");

            error_report(

"Guest requested unavailable interrupt mode (XIVE), try the ic-mode=xive or ic-mode=dual machine property");

            exit(EXIT_FAILURE);

        }

    } else {

        if (spapr->irq->ov5 == SPAPR_OV5_XIVE_EXPLOIT) {

            error_report("Guest requested unavailable interrupt mode (XICS)");

            error_report(

"Guest requested unavailable interrupt mode (XICS), either don't set the ic-mode machine property or try ic-mode=xics or ic-mode=dual");

            exit(EXIT_FAILURE);

        }

    }