Commit 75c6d92e authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Peter Maydell
Browse files

hw/char/exynos4210_uart: Constify static array and few arguments 



The static array exynos4210_uart_regs with register values is not
modified so it can be made const.

Few other functions accept driver or uart state as an argument but they
do not change it and do not cast it so this can be made const for code
safeness.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Message-id: 20170313184750.429-3-krzk@kernel.org
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent f2ad5140

hw/char/exynos4210_uart.c

+4 −4
Original line number Diff line number Diff line
@@ -102,7 +102,7 @@ typedef struct Exynos4210UartReg { 
    uint32_t            reset_value;

} Exynos4210UartReg;



static Exynos4210UartReg exynos4210_uart_regs[] = {

static const Exynos4210UartReg exynos4210_uart_regs[] = {

    {"ULCON",    ULCON,    0x00000000},

    {"UCON",     UCON,     0x00003000},

    {"UFCON",    UFCON,    0x00000000},
@@ -220,7 +220,7 @@ static uint8_t fifo_retrieve(Exynos4210UartFIFO *q) 
    return  ret;

}



static int fifo_elements_number(Exynos4210UartFIFO *q)

static int fifo_elements_number(const Exynos4210UartFIFO *q)

{

    if (q->sp < q->rp) {

        return q->size - q->rp + q->sp;
@@ -229,7 +229,7 @@ static int fifo_elements_number(Exynos4210UartFIFO *q) 
    return q->sp - q->rp;

}



static int fifo_empty_elements_number(Exynos4210UartFIFO *q)

static int fifo_empty_elements_number(const Exynos4210UartFIFO *q)

{

    return q->size - fifo_elements_number(q);

}
@@ -245,7 +245,7 @@ static void fifo_reset(Exynos4210UartFIFO *q) 
    q->rp = 0;

}



static uint32_t exynos4210_uart_Tx_FIFO_trigger_level(Exynos4210UartState *s)

static uint32_t exynos4210_uart_Tx_FIFO_trigger_level(const Exynos4210UartState *s)

{

    uint32_t level = 0;

    uint32_t reg;