Commit 73374683 authored by Markus Armbruster's avatar Markus Armbruster
Browse files

tests/string-input-visitor: Add negative integer tests 



Add two negative tests, one for int and one for int16List.  The latter
exposes a bug: nonsensical input results in an empty list instead of
an error.

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Message-Id: <1461325048-14122-1-git-send-email-armbru@redhat.com>
Signed-off-by: default avatarEric Blake <eblake@redhat.com>
Message-Id: <1461879932-9020-22-git-send-email-eblake@redhat.com>
parent 15c2f669

tests/test-string-input-visitor.c

+15 −0
Original line number Diff line number Diff line
@@ -63,6 +63,13 @@ static void test_visitor_in_int(TestInputVisitorData *data, 
    visit_type_int(v, NULL, &res, &err);

    g_assert(!err);

    g_assert_cmpint(res, ==, value);



    visitor_input_teardown(data, unused);



    v = visitor_input_test_init(data, "not an int");



    visit_type_int(v, NULL, &res, &err);

    error_free_or_abort(&err);

}



static void test_visitor_in_intList(TestInputVisitorData *data,
@@ -70,6 +77,7 @@ static void test_visitor_in_intList(TestInputVisitorData *data, 
{

    int64_t value[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 20};

    int16List *res = NULL, *tmp;

    Error *err = NULL;

    Visitor *v;

    int i = 0;
@@ -90,6 +98,13 @@ static void test_visitor_in_intList(TestInputVisitorData *data, 
        g_free(tmp);

        tmp = res;

    }



    visitor_input_teardown(data, unused);



    v = visitor_input_test_init(data, "not an int list");



    visit_type_int16List(v, NULL, &res, &err);

    /* FIXME fix the visitor, then error_free_or_abort(&err) here */

}



static void test_visitor_in_bool(TestInputVisitorData *data,