Commit 728b1429 authored Oct 05, 2016 by Eduardo Habkost Committed by Markus Armbruster Oct 07, 2016

qmp: Disable query-cpu-* commands when they're unavailable



Instead of requiring clients to actually call the query-cpu-*
commands to find out if they are implemented, remove them from
the output of "query-commands", so clients know they are not
available.

This is implemented by extending the existing hack at
qmp_unregister_commands_hack(). I wish I could avoid adding even
more #ifdefs to that code, but that's the solution we have today.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <1475696941-8056-1-git-send-email-ehabkost@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>

parent daf5dc78

monitor.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -992,6 +992,15 @@ static void qmp_unregister_commands_hack(void)
		#ifndef TARGET_ARM
		qmp_unregister_command("query-gic-capabilities");
		#endif
		#if !defined(TARGET_S390X)
		qmp_unregister_command("query-cpu-model-expansion");
		qmp_unregister_command("query-cpu-model-baseline");
		qmp_unregister_command("query-cpu-model-comparison");
		#endif
		#if !defined(TARGET_PPC) && !defined(TARGET_ARM) && !defined(TARGET_I386) \
		&& !defined(TARGET_S390X)
		qmp_unregister_command("query-cpu-definitions");
		#endif
		}

		static void qmp_init_marshal(void)