Commit 7237aecd authored by Fam Zheng's avatar Fam Zheng Committed by Kevin Wolf
Browse files

vmdk: Widen before shifting 32 bit header field 



Coverity spotted this.

The field is 32 bits, but if it's possible to overflow in 32 bit
left shift.

Signed-off-by: default avatarFam Zheng <famz@redhat.com>
Reviewed-by: default avatarJohn Snow <jsnow@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent 5505e8b7

block/vmdk.c

+1 −1
Original line number Diff line number Diff line
@@ -523,7 +523,7 @@ static int vmdk_open_vmfs_sparse(BlockDriverState *bs, 
    }

    ret = vmdk_add_extent(bs, file, false,

                          le32_to_cpu(header.disk_sectors),

                          le32_to_cpu(header.l1dir_offset) << 9,

                          (int64_t)le32_to_cpu(header.l1dir_offset) << 9,

                          0,

                          le32_to_cpu(header.l1dir_size),

                          4096,