Commit 71429097 authored by Peter Maydell's avatar Peter Maydell Committed by Michael Tokarev
Browse files

configure: disable clang -Wstring-plus-int warning 



Some versions of clang will warn about adding integers to strings:

disas/i386.c:4753:23: error: adding 'char' to a string does not append
      to the string [-Werror,-Wstring-plus-int]
      oappend ("%es:" + intel_syntax);
               ~~~~~~~^~~~~~~~~~~~~~
disas/i386.c:4753:23: note: use array indexing to silence this warning
      oappend ("%es:" + intel_syntax);
                      ^
               &      [             ]

disas/i386.c uses this idiom to to skip a "%" prefix if using intel
rather than AT&T syntax. This seems like a reasonable  thing to do,
and I don't think anybody contributing to QEMU is likely to believe
that '+' is a string concatenation operator in C, so just disable
-Wstring-plus-int.

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent c89aa2f1

configure

+1 −0
Original line number Diff line number Diff line
@@ -1204,6 +1204,7 @@ gcc_flags="-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers $gcc_ 
gcc_flags="-Wmissing-include-dirs -Wempty-body -Wnested-externs $gcc_flags"

gcc_flags="-Wendif-labels $gcc_flags"

gcc_flags="-Wno-initializer-overrides $gcc_flags"

gcc_flags="-Wno-string-plus-int $gcc_flags"

# Note that we do not add -Werror to gcc_flags here, because that would

# enable it for all configure tests. If a configure test failed due

# to -Werror this would just silently disable some features,