Commit 712b4243 authored by Eduardo Habkost's avatar Eduardo Habkost
Browse files

target-i386: Don't left shift negative constant 



Left shift of negative values is undefined behavior. Detected by clang:
  qemu/target-i386/translate.c:2423:26: runtime error:
    left shift of negative value -8

This changes the code to reverse the sign after the left shift.

Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent 7e038b94

target-i386/translate.c

+1 −1
Original line number Diff line number Diff line
@@ -2432,7 +2432,7 @@ static void gen_pusha(DisasContext *s) 
{

    int i;

    gen_op_movl_A0_reg(R_ESP);

    gen_op_addl_A0_im(-8 << s->dflag);

    gen_op_addl_A0_im(-(8 << s->dflag));

    if (!s->ss32)

        tcg_gen_ext16u_tl(cpu_A0, cpu_A0);

    tcg_gen_mov_tl(cpu_T[1], cpu_A0);