Commit 7111a86e authored by Markus Armbruster's avatar Markus Armbruster
Browse files

qapi: Assert non-input visitors see only valid alternate tags 



An alternate type's visit_type_FOO() fails when it runs into an
invalid ->type.

This is appropriate with an input visitor: visit_start_alternate()
sets ->type according to the input, and bad input can lead to bad
->type.

It should never happen with an output, clone or dealloc visitor: if it
did, the alternate being output, cloned or deallocated would be messed
up beyond repair.  Assert that.

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Message-Id: <20200424084338.26803-12-armbru@redhat.com>
parent c978bd52

scripts/qapi/visit.py

+1 −0
Original line number Diff line number Diff line
@@ -232,6 +232,7 @@ void visit_type_%(c_name)s(Visitor *v, const char *name, %(c_name)s **obj, Error 
    case QTYPE_NONE:

        abort();

    default:

        assert(visit_is_input(v));

        error_setg(&err, QERR_INVALID_PARAMETER_TYPE, name ? name : "null",

                   "%(name)s");

        /* Avoid passing invalid *obj to qapi_free_%(c_name)s() */