Commit 70afb8ff authored by Stefan Weil's avatar Stefan Weil Committed by Aurelien Jarno
Browse files

darwin-user: Remove unneeded null pointer check 



cppcheck reports this error:

commpage.c:223: error: Possible null pointer dereference:
value - otherwise it is redundant to check if value is null at line 214

The null pointer check in line 214 is indeed not needed.
If value were null, the code would crash in line 223.
See do_compare_and_swap64 were for a reference.

Signed-off-by: default avatarStefan Weil <weil@mail.berlios.de>
Signed-off-by: default avatarAurelien Jarno <aurelien@aurel32.net>
parent aa348082

darwin-user/commpage.c

+1 −1
Original line number Diff line number Diff line
@@ -211,7 +211,7 @@ void do_compare_and_swap32(void *cpu_env, int num) 
    uint32_t *value = (uint32_t*)((CPUX86State*)cpu_env)->regs[R_ECX];

    DPRINTF("commpage: compare_and_swap32(%x,new,%p)\n", old, value);



    if(value && old == tswap32(*value))

    if(old == tswap32(*value))

    {

        uint32_t new = ((CPUX86State*)cpu_env)->regs[R_EDX];

        *value = tswap32(new);